.

Items to CheckReferences and NotesReferences and Notes

.

Workspace

.

.

Am I using the MTJ's Clean Up Template?http://wiki.eclipse.org/DSDP/MTJ/Developer_Resources/Coding_Standards

.

Am I using the MTJ's Formatter Template?http://wiki.eclipse.org/DSDP/MTJ/Developer_Resources/Coding_Standards

.

Am I using 1.5 on the Compiler Compliance Level?

.

.

Bugzilla

.

.

Did I posted my intent to fix the bug?https://bugs.eclipse.org/bugs/show_bug.cgi?id=282738#c2

.

Did I posted all my doubts about the bug?

.

I couldn't reproduce the issue reported on the bug. Did I add a note asking for more information?

.

My patch changed the default behavior of a feature. Did I posted in the bug the new behavior?https://bugs.eclipse.org/bugs/show_bug.cgi?id=284452#c2

.

After posting my patch, did I requested review?https://bugs.eclipse.org/bugs/show_bug.cgi?id=282738#c4

.

After posting my patch, did I confirmed that wrote 100% of the code and have the right to contribute the code to Eclipse?http://wiki.eclipse.org/DSDP/MTJ/Developer_Resources/Contributor_Confirmations

.

Did I checked if my patch fix only the bug I'm submitting it to?If your patch fix more then one but at a time, document it on bugzilla, listing all bugs affected by this correction.

.

My previous patch wasn't accepted. Did I marked the last contribution as obsolete?

.

My previous patch wasn't accepted but I received a list of modifications to implement. Does my new patch cover this modifications?If You were advised to make modifications, and you don't agree with them, document it on the bug

.

Did I included the Keyword "contributed" to the keywords section?

.

I found another bug while implement my solution, did I reported it?If you find a bug that is not related to your fix, please report it.

.

.

.

Copyright

.

.

The modification date was updated on all files?

.

A note was added indicating the modification on each file?

.

New files have default copyright?http://www.eclipse.org/legal/copyrightandlicensenotice.php

.

Did the copyright on each piece of code imported from other eclipse projects documented?http://wiki.eclipse.org/DSDP/MTJ/Developer_Resources/Copyright_Standards

.

.

Code

.

.

Did I included new API classes without prior permission from the Committers Group?Always consult the Committers Group before including new APIs.

.

Did I Changed an existing API classes without prior permission from the Committers Group?Always consult the Committers Group before changing APIs.

.

Did I implemented a new feature without consulting with the Committers Group?Always consult the Committers Group before including new features.

.

Did I Removed Classes without consulting with the Committers Group?Always consult the Committers Group before excluding Classes.

.

Did I checked for Dead Code on my implementation?

.

Am I using methods from java 1.6 or higher?Code must be 1.5 compliant

.

Did I add comments to new classes?

.

Did I add comments on new methods?

.

Did I formatted code before creating a patch?http://wiki.eclipse.org/DSDP/MTJ/Developer_Resources/Coding_Standards

.

Did I cleaned up the code before submitting a patch?http://wiki.eclipse.org/DSDP/MTJ/Developer_Resources/Coding_Standards

.

Does my code handle Exceptions correctly?Exception shouldn’t be thrown to the UI.

.

Did I checked if MTJ already provides an internal API that can be used inside my code, instead of recreating it from scratch?MTJ provides a series of internal APIs for working i.e. with images, Label Providers, Preferences; You should try to use one of them instead of recreating it from scratch.

.

Did I Externalized all Strings that will be displayed in the UI?http://help.eclipse.org/help33/topic/org.eclipse.jdt.doc.user/concepts/cnls.htm

.

.

Documentation

.

.

Did I updated the User Documentation?

.

If I don't want to update the user doc, did I reported on the bug that someone should do that?If you don't whant to help updating the user docummentation, at least report the necessity of an update.

.

.

Test

.

.

Did I tested enough scenários before submitting the patch?

.

Did I tested my code for common programming errors (NullPointerException, ClassCastException, CoreException)

.

.

.

.

Revise

.

.

My code was integrated and released in a NB. Did I checked if it was correctly integrated, working as expected?

.

My code was integrated. Did I checked if my contribution was included in the IP Log?http://www.eclipse.org/dsdp/mtj/ipLog.php

.

.